Incompressible fix/periodic channel/transport model consolidation

AMReX-Combustion / PeleLMeX

An adaptive mesh hydrodynamics simulation code for low Mach number reacting flows without level sub-cycling.

https://amrex-combustion.github.io/PeleLMeX/

BSD 3-Clause "New" or "Revised" License

24 stars 32 forks source link

Incompressible fix/periodic channel/transport model consolidation #350

Closed ThomasHowarth closed 3 months ago

ThomasHowarth commented 4 months ago

This PR does the following:

Fixes the incompressible flag problem raised in #340
Adds the ability to automatically adjust the pressure gradient for a periodic channel flow to maintain the mass flow rate given by the initial condition
Consolidates various transport models into a single function, including generalising the fixed diffusion coefficients, and adding in a scaling that is required for accurate Soret coefficients. This also addresses issue #337

ThomasHowarth commented 4 months ago

I have made all the specified changes. It is perhaps a little convoluted when it comes to the various models possible. Currently, if we run without LES you can fixed Le or Pr. It doesn't need to be both, but both would obviously lead to fixed Sc. With LES, we automatically run with fixed Pr/Sc (and hence fixed Le). Pr and Sc are specified in this case. Hopefully that makes sense, or happy to take suggestions.