search

AMReX-Combustion / PelePhysics

A collection of physics databases and implementation code for use with the Pele suite of of codes
https://amrex-combustion.github.io/PelePhysics/
Other
60 stars 52 forks source link

Simplify Make.package in mechanisms #515

Closed baperry2 closed 3 months ago

baperry2 commented 3 months ago

Get rid of a bunch of extraneous/deprecated stuff in the Make.package files for each mechanism.

marchdf commented 3 months ago

Ah wait there's a reason for some of these. I remember trying to remove them and then @esclapez said something that made me change my mind. Any chance you can repeat that info here @esclapez ?

baperry2 commented 3 months ago

I'm pretty sure the PMFs directory is hold over from a long long time ago when PMF data was compiled as source code. The rest of it I think should be ok as long as everything compiles, although I didn't verify that for LMeX/C, will do that now. But @esclapez feel free to jump in if there's something I'm missing.

baperry2 commented 3 months ago

Going to merge this because it doesn't appear to cause any issues building C or LMeX.