AMReX-Combustion / PelePhysics

A collection of physics databases and implementation code for use with the Pele suite of of codes
https://amrex-combustion.github.io/PelePhysics/
Other
61 stars 52 forks source link

speciesNames for Manifold EOS #542

Open baperry2 opened 1 week ago

baperry2 commented 1 week ago

These get read from the table metadata rather than specified at compile time. Therefore, to define them, eosparm needs to be passed to the appropriate function. The implementation should be backward compatible and only require the modified call signature when using Manifold EOS.

This PR also modifies the out-of-class EOS function templates work to eliminate EOS.cpp and reduce redundant code, but perhaps is less readable? Open to suggestion on this.

marchdf commented 1 week ago

I am fine with this moving the definitions to the header. The only thing is making sure the linkers don't hit "multiple definition" type of errors.

baperry2 commented 1 week ago

The multiple definition error is resolved by marking the template specializations as inline