Open isriva opened 2 years ago
@jbbel I have started this branch to check for the errors associated with boundary conditions in cell-centered compressible FHD: https://github.com/AMReX-FHD/FHDeX/tree/fix_compres_center
The error appears to be at the high boundary (in all directions). Here is an example of the error: local density variance in an equilibrium simulation.
do you view noslip at left boundary as ok? also do we see same behavior with adiabatic
The behavior is the same with adiabatic. I think the no-slip is ok on the left (the difference could be in the noise -- but I will check closely).
i believe I have identified the issue and fixed the problem. at least for noslip isothermal walls in z direction things seem to be correct
The issue above seems to be fixed, but the variance for density (and also energy) seem incorrect for noslip -- looks like it is correct for slip -- see below ...
The cell-centered code for compressible FHD has several outstanding issues listed below. A major re-factor of the code was performed in Feb 2022 for a better prescription of the Dirichlet boundary conditions in the PR https://github.com/AMReX-FHD/FHDeX/pull/98. In this PR, Dirichlet boundary conditions are assigned at the boundaries rather than a linear extrapolation to ghost cells for increased numerical stability. However several issues have emerged, both after the PR (post-Feb version) and before the PR (pre-Feb version)