search

AMReX-Fluids / AMReX-Hydro

AMReX-based hydro routines
https://amrex-fluids.github.io/amrex-hydro/docs_html
Other
13 stars 25 forks source link

Fix host access of device pointer in BDS #101

Closed marchdf closed 1 year ago

marchdf commented 1 year ago

The host accesses the BC device pointer in BDS. This is fine if amrex.the_arena_is_managed=1 but not when amrex.the_arena_is_managed=0. This PR passes the host data through and accesses that instead.

The BC device pointer data is kept but it isn't used anymore. I kept it in case someone ever wanted to access the BCs on device in BDS later but I am happy to remove as well.

cgilet commented 1 year ago

Looks like we can let go of the device bc for Slopes though

marchdf commented 1 year ago

@cgilet thanks for the comments! I removed pbc from the slopes and addressed your other comment.