search

AMReX-Fluids / AMReX-Hydro

AMReX-based hydro routines
https://amrex-fluids.github.io/amrex-hydro/docs_html
Other
11 stars 24 forks source link

const geom argument in ExtrapVelToFaces #94

Closed marchdf closed 1 year ago

marchdf commented 1 year ago

I was having issues with non-const geom argument in ExtrapVelToFaces. It's const in Godunov and MOL but not in HydroUtils so I am just making it behave the same.

marchdf commented 1 year ago

I am not sure why CUDA / CUDA@11.2 GNU@9.4 is failing. I tried 11.2 and GCC 9.3 on a local machine and it worked. The github CI is not giving me any information on that test so I think it's a problem with GH and not the code in this PR. CUDA 10 seems fine here as well.

WeiqunZhang commented 1 year ago

I restarted the failed job.

marchdf commented 1 year ago

Great! It looks like that did the trick.