search

AMReX-Fluids / IAMR

A parallel, adaptive mesh refinement (AMR) code that solves the variable-density incompressible Navier-Stokes equations.
https://amrex-fluids.github.io/IAMR/
80 stars 57 forks source link

Remove unused Fortran interface function and minor updates and cleanup #129

Closed esclapez closed 2 years ago

esclapez commented 2 years ago

to reduce the amount of complaints from cland-tidy.

cgilet commented 2 years ago

@esclapez Thanks for this clean up! However, I don't see a removed fortran interface. Did you forget to commit that part?

esclapez commented 2 years ago

It was this small piece (in the middle of NSBase.cpp):

BL_FORT_PROC_DECL(BL_NS_DOTRAC2,bl_ns_dotrac2)(int* dotrac2)
{
    *dotrac2 = NavierStokesBase::DoTrac2();
}

When I tried switching off fortran for CMake, it no longer recognized the BLFORT* macro.

cgilet commented 2 years ago

that function (c++ or fortran version) never even gets call. thanks @esclapez for cleaning this up!