AMReX-Fluids / IAMR

A parallel, adaptive mesh refinement (AMR) code that solves the variable-density incompressible Navier-Stokes equations.
https://amrex-fluids.github.io/IAMR/
80 stars 57 forks source link

Move scalar/temp + EBGodunov test from NSB -> NS. #92

Closed esclapez closed 3 years ago

esclapez commented 3 years ago

Move scalar/temp + EBGodunov checks from NSB -> NS.

cgilet commented 3 years ago

@esclapez Silly question: I thought you're putting a non-conservative option in EBGodunov, so why are we moving these warnings rather than just removing them?

esclapez commented 3 years ago

When the non-conservative is up and running, I think they could be harmless in NSB but it seems that these tests are related to things that seems to be a constrains on NS rather than NSB.