BCType::foextrap as default for (density, BC::slip_wall) combination when advection_type == "BDS"

AMReX-Fluids / incflo

Incompressible Navier-Stokes solver in complex geometries

https://amrex-fluids.github.io/incflo

BSD 3-Clause "New" or "Revised" License

46 stars 28 forks source link

BCType::foextrap as default for (density, BC::slip_wall) combination when advection_type == "BDS" #113

Closed siddanib closed 3 months ago

siddanib commented 3 months ago

Making BCType::foextrap as the default type for density and tracer at BC::slip_wall boundary only when advection_type == "BDS". Also made a minor change in docs (src/boundary_conditions/README.org) for (scalar/density, sw) combination.

ajnonaka commented 3 months ago

Hold off on merging - we should consider making all scalars operate the same way.

siddanib commented 3 months ago

Thank you for the suggestions, Andy (@ajnonaka)! I believe I might have to rebase based on #114 to pass all the checks.

cgilet commented 3 months ago

The velocity uses hoextrap for the tangential components for slip wall. Would that also be incorrect with BDS?

ajnonaka commented 3 months ago

hoextrap for BDS + velocity is fine - we don't have local min/max constraints.