search

AMSP-04 / NETN-ETR

NATO Education and Training Network (NETN) Entity Tasking and Reporting (ETR) Module
Other
2 stars 0 forks source link

Inconsistency between ETR-FOM releases #51

Closed bergtwvd closed 3 years ago

bergtwvd commented 3 years ago

The ETR-FOM version in the master branch of this repository is different (and has errors) from the ETR FOM version in the release package of the NETN-FOM repository (https://github.com/AMSP-04/NETN-FOM/releases).

For example, in this repository:

Currently I use the FOMs in the release repository.

This repo:

                <interactionClass>
                    <name>ETR_Report</name>
                    <sharing>Neither</sharing>
                    <transportation>HLAreliable</transportation>
                    <order>Receive</order>
                    <semantics>A base interaction class for more specialized report interaction classes.</semantics>
                    <parameter>
                        <name>ReportId</name>
                        <dataType>TransactionId</dataType>
                        <semantics>Required. Uniqie identifier for the report.</semantics>
                    </parameter>
                    <parameter>
                        <name>When</name>
                        <dataType>Datetime18</dataType>
                        <semantics>Required. Date and time when the reported status was valid.</semantics>
                    </parameter>
                    <parameter>
                        <name>CommunicationNetworkIds</name>
                        <dataType>ArrayOfText64</dataType>
                        <semantics>Optional. Reference to communication networks (NETN-COM) used to transfer report messages. If not provided, the report transmission should not be modelled and federates should receive and act on the report messages directly.</semantics>
                    </parameter>
                    <parameter>
                        <name>Comments</name>
                        <dataType>HLAunicodeString</dataType>
                        <semantics>Optional. Any additional comments associated with the report.</semantics>
                    </parameter>
                    <parameter>
                        <name>CommunicationNetworkIds</name>
                        <dataType>ArrayOfUuid</dataType>
                        <semantics>List with ids to CommunicationNetworkIdentifier that represents the communication network.

Optional.</semantics>
                    </parameter>
                    <interactionClass>
                        <name>InWeaponRangeReport</name>
lofstrandbjorn commented 3 years ago

I will investigate and correct ASAP.

lofstrandbjorn commented 3 years ago

The release of the ETR module seems to be fine and the same as in the NETN-FOM release. The problem may have occured when merging the release branch with the master branch.

lofstrandbjorn commented 3 years ago

Will replace the module file in the master branch with the correct released version. I am not quite sure how this happened but when looking at the pull requests it indicates the areas of concern and it appears that it has not been taken into consideration when comparing the files for merging. In any case, there are two issues: The CommunicationNetworksId duplication of the ETR_Report interaction class and a duplication of UniqueId of the AddPassage interaction class.