search

AMWA-TV / bcp-005-01

AMWA BCP-005-01 NMOS EDID to Receiver Capabilities Mapping
https://specs.amwa.tv/bcp-005-01
Apache License 2.0
3 stars 4 forks source link

Minor language/formatting issues #63

Closed garethsb closed 2 years ago

garethsb commented 2 years ago

Each video timing SHOULD be present in the Receiver’s Capabilities as a Constraint Set with a non-empty [...]

This seems to imply (recommend) a one-to-one mapping but if several video timings can be expressed more concisely, e.g. one combination of frame_width and frame_height with several frame_rate values as a single Constraint Set, wouldn't that be OK?

Each of these Parameter Constraints MUST use enum Constraint Keyword.

When the required constraint can be expressed via min/max, why not allow that?

Also, meta:preference appears to be included in a list to which one instance of the above sentence refers; probably best to rejig that?

One use of SHALL... although RFC 2119 allows both SHALL and MUST, the NMOS specs try to use the latter consistently. (The sentence in question may need rewriting slightly anyway since it uses SHALL to introduce the bullets which then each have MUST in them.)

One instance of "off" where I think "of" is meant.

Possibly inconsistent use of italics vs roman for some EDID spec terms?

garethsb commented 2 years ago

s/Prefered/Preferred

s/BLock/Block

> If Basic Audio support bit is
---
< If the Basic Audio support bit is
garethsb commented 2 years ago

This value MUST be transformed into urn:x-nmos:cap:format:color_sampling with enum values according to those permitted by the NMOS Parameter Registers - Capabilities section and added to each Constraint Set.

The link in this sentence should probably go to published specs.amwa.tv URL, and could go directly to the precise fragment... https://specs.amwa.tv/nmos-parameter-registers/branches/main/capabilities/#color-sampling