search

AMWA-TV / is-06

AMWA IS-06 NMOS Network Control Specification (Deprecated)
https://specs.amwa.tv/is-06
Apache License 2.0
14 stars 10 forks source link

attached_network_device (merge to lldp-2 branch) #66

Closed garethsb closed 4 years ago

garethsb commented 4 years ago

Make Endpoint attached_network_device optional - though strongly recommended - to allow operation in the case that these details are not available to the BC, cf. IS-04 Node /self interfaces.attached_network_device being optional.

Reasonable?

garethsb commented 4 years ago

One concern that has been raised with this is whether for example when running SR-IOV on a NIC, any or all LLDP transmissions from the virtual function interfaces will reach the switch that's part of the IS-06 system. If not, the network controller would not be able to identify where the Endpoint is connected automatically and it must be registered with the attached_network_device info.

The best practice would be to enable LLDP on every network device and endpoint, and mandate that the IS-04 Node includes interfaces.attached_network_device but since it is hard to change IS-04 in this regard, this proposed change, plus a warning in the IS-04 Node test suite (https://github.com/AMWA-TV/nmos-testing/issues/491) could be the best option.

vsachin33 commented 4 years ago

I understand that we would need to make attached_network_device optional for IS-04 consistency but as discussed offline there are cases in BC/NC communication where device info is mandatory. BTW I merged pull request ..Sachin