search

AMWA-TV / nmos-testing

Testing tool for the AMWA NMOS Specifications
https://specs.amwa.tv/nmos-testing/
Apache License 2.0
42 stars 48 forks source link

NMOS Test Suite mock registries are HTTP/1.0 #120

Open garethsb opened 5 years ago

garethsb commented 5 years ago

I don't think the NMOS specs discuss differences between HTTP/1.1 and HTTP/1.0, or indicate a recommendation either way?

However, the fact that the test suite's Registries are currently HTTP/1.0 identified a bug in the HTTP implementation of cpprestsdk, which means it doesn't properly handle HTTP/1.0 servers that don't do "Connection: Keep-Alive". (Fix available at https://github.com/Microsoft/cpprestsdk/pull/1032.)

So, I'm not opposed to the test suite testing HTTP/1.0... but did it ought at least check HTTP/1.1 as well?

andrewbonney commented 5 years ago

Fwiw I had a try replacing the basic Flask web server with Werkzeug (which as noted it at least partially uses anyway). Unfortunately this still returned an HTTP/1.0 response.

garethsb commented 5 years ago

There appears to be a SERVER_PROTOCOL config for Werkzeug if I understand my Googling correctly.

andrewbonney commented 5 years ago

Yes, I came across that (at least in something testing related), but it seems to default to HTTP/1.1 anyway

andrewbonney commented 5 years ago

I'm wondering if it might be necessary to provide instructions for use with a full WSGI compatible web server in order to achieve this (for example https://uwsgi-docs.readthedocs.io/en/latest/WSGIquickstart.html#deploying-flask). I've not seen anything concrete, but running the 'development' web server may only be capable of HTTP/1.0