search

AMWA-TV / nmos-testing

Testing tool for the AMWA NMOS Specifications
https://specs.amwa.tv/nmos-testing/
Apache License 2.0
42 stars 48 forks source link

IS-05 tests attempting to set RTP transport parameters that are not valid according to the Sender's constraints #690

Open alabou opened 2 years ago

alabou commented 2 years ago

https://github.com/AMWA-TV/nmos-testing/blob/758670dcd154af9c601d75e8d710725262893bb5/nmostesting/suites/IS0502Test.py#L501

We observe that test_10 and test_11 (but the issue seems to be generic to all similar tests) attempt in our case to setup a unicast destination_ip IPv4 address on a Sender while the Sender 1) has its transport attribute set to "urn:x-nmos:transport:rtp.mcast" and 2) the Sender destination_ip constraint is a multicast pattern destination_ip: { pattern: "^(2(2[4-9]|3[0-9]))(\.([0-9]|[1-9][0-9]|1([0-9][0-9])|2([0-4][0-9]|5[0-5]))){3}$" }

It seems that the IS-05 test should verify the RTP transport parameter constraints and apply parameters that are compliant with those constraints as allowed by the IS-05 specification.

garethsb commented 2 years ago

The test case test_10 is specifically designed to test unicast RTP, as there is a previous test case which is more or less identical that checks multicast RTP. Rather than a "Fail", a sender which doesn't support unicast RTP ought to get a "Not Implemented" result. For JT-NM Tested August 2022, maybe no change is necessary as failures and not implemented will be indicated in the results chart the same way...

garethsb commented 2 years ago

See also #621...