AMWA-TV / sdpoker

A patched version of Streampunk/sdpoker with additional source-filter testing and bug fixes, used by AMWA-TV/nmos-testing
Apache License 2.0
12 stars 8 forks source link

a=mediaclk:direct syntax #1

Open garethsb opened 4 years ago

garethsb commented 4 years ago

RFC 7273 says:

direct = "direct" [ "=" 1*DIGIT ] [SP rate]
rate   = "rate=" integer "/" integer

However, the tests for this only check the first part and allow any string for the rate part. And the makeSDP function doesn't appear to put the / and denominator in the generated value.

(I've also seen a=mediaclk:direct=0 rate=48000 in the wild.)