AMWA-TV / sdpoker

A patched version of Streampunk/sdpoker with additional source-filter testing and bug fixes, used by AMWA-TV/nmos-testing
Apache License 2.0
12 stars 8 forks source link

Support empty <format specific parameters> in a=fmtp: line #15

Closed garethsb closed 1 year ago

garethsb commented 2 years ago

Proposed fix for #14.

Note that there's still more to do to bring ST 2110-40 testing up to same level as ST 2110-20, see #4. And #11 is required ASAP as well, now the ST 2110-xx:2022 revisions are imminent.

garethsb commented 2 years ago

Note that there's still the existing bug that if the a=fmtp: line appears before the a=rtpmap: line, e.g. test_20_72_1 fails because extractMTParams doesn't work out it needs to skip the format specific parameter checks in time. Luckily, all files I've seen in the wild order rtpmap before fmtp.