search

AMWA-TV / sdpoker

A patched version of Streampunk/sdpoker with additional source-filter testing and bug fixes, used by AMWA-TV/nmos-testing
Apache License 2.0
12 stars 8 forks source link

Example SDPs need to use CRLF #16

Closed kierank closed 2 years ago

kierank commented 2 years ago

As per RFC 8866, CRLF is what ends a line yet examples have LF only.

garethsb commented 2 years ago

The files in examples directory? They're probably committed as text files, so what you gets depends on platform.

I agree ideally they should check out with CRLF on all platforms.

Though as per RFC 4566, "parsers SHOULD be tolerant and also accept records terminated with a single newline character."

kierank commented 2 years ago

I did a wget from the "Raw" tab of GitHub but yes I'm not sure if it does any processing.

Kieran

Sent from my mobile device

On Tue, 1 Nov 2022, 17:40 Gareth Sylvester-Bradley, < @.***> wrote:

The files in examples directory? They're probably committed as text files, so what you gets depends on platform.

I agree ideally they should check out with CRLF on all platforms.

Though as per RFC 4566, "parsers SHOULD be tolerant and also accept records terminated with a single newline character."

— Reply to this email directly, view it on GitHub https://github.com/AMWA-TV/sdpoker/issues/16#issuecomment-1298882666, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDEEE73ULS3F6P6Q636A3WGFIXHANCNFSM6AAAAAARUHDI3A . You are receiving this because you authored the thread.Message ID: @.***>

garethsb commented 2 years ago

Should be resolved by #18 on new clones.