search

AMacro / dv-multiplayer

A DerailValley mod adding multiplayer to the game.
Apache License 2.0
21 stars 3 forks source link

ClientboundJobsCreatePacket crash when connecting #48

Open matejdro opened 2 months ago

matejdro commented 2 months ago

We found that sometimes, when client attempts to connect to the server, it will get stuck on the connecting screen with the following error being printed to the logs:

[17:06:33.510] [Error] [Client] Exception while polling events: System.NullReferenceException: Object reference not set to an instance of an object
  at Multiplayer.Networking.Data.TransportTaskData.ToTask () [0x00078] in <d2f67c64b0c144d8bc4c908418b1378d>:0 
  at Multiplayer.Components.Networking.World.NetworkedStationController.AddJobs (Multiplayer.Networking.Data.JobData[] jobs) [0x0003d] in <d2f67c64b0c144d8bc4c908418b1378d>:0 
  at Multiplayer.Networking.Listeners.NetworkClient.OnClientboundJobsCreatePacket (Multiplayer.Networking.Packets.Clientbound.Jobs.ClientboundJobsCreatePacket packet) [0x00067] in <d2f67c64b0c144d8bc4c908418b1378d>:0 
  at LiteNetLib.Utils.NetPacketProcessor+<>c__DisplayClass28_0`1[T].<SubscribeReusable>b__0 (LiteNetLib.Utils.NetDataReader reader, System.Object userData) [0x00018] in <2af6a78ac53a4d3dbe588de2359878e4>:0 
  at LiteNetLib.Utils.NetPacketProcessor.ReadPacket (LiteNetLib.Utils.NetDataReader reader, System.Object userData) [0x00007] in <2af6a78ac53a4d3dbe588de2359878e4>:0 
  at LiteNetLib.Utils.NetPacketProcessor.ReadAllPackets (LiteNetLib.Utils.NetDataReader reader, System.Object userData) [0x00002] in <2af6a78ac53a4d3dbe588de2359878e4>:0 
  at Multiplayer.Networking.Listeners.NetworkManager.OnNetworkReceive (LiteNetLib.NetPeer peer, LiteNetLib.NetPacketReader reader, System.Byte channelNumber, LiteNetLib.DeliveryMethod deliveryMethod) [0x00007] in <d2f67c64b0c144d8bc4c908418b1378d>:0 
  at LiteNetLib.NetManager.ProcessEvent (LiteNetLib.NetEvent evt) [0x000a5] in <2af6a78ac53a4d3dbe588de2359878e4>:0 
  at LiteNetLib.NetManager.PollEvents () [0x0008c] in <2af6a78ac53a4d3dbe588de2359878e4>:0 
  at Multiplayer.Networking.Listeners.NetworkManager.PollEvents () [0x00000] in <d2f67c64b0c144d8bc4c908418b1378d>:0 
  at Multiplayer.Components.Networking.NetworkLifecycle.TickManager (Multiplayer.Networking.Listeners.NetworkManager manager) [0x00021] in <d2f67c64b0c144d8bc4c908418b1378d>:0

Followed by a lot of the:

Failed to parse packet: Undefined packet 35 in NetDataReader

Full log from that client: ShadeCrash.txt

Note that we experienced this with the Rolling Stock Ownership mod installed. If crashes when running other mods are out of scope, please feel free to close this issue.

AMacro commented 2 months ago

This is a known issue that we'll be tackling this weekend - it may / or may not be exaserbated by the use of other mods