AMereBagatelle / fabricskyboxes

Custom skyboxes mod for Fabric
MIT License
77 stars 22 forks source link

Use `mc-publish` for Modrinth and CurseForge releases #38

Closed FlashyReese closed 2 years ago

FlashyReese commented 2 years ago

Resolves https://github.com/AMereBagatelle/fabricskyboxes/issues/27

If you do consider merging this, please be sure to add the CURSEFORGE_TOKEN environment variables.

AMereBagatelle commented 2 years ago

Looks generally good, however I have one question. What happens if either Modrinth or CurseForge is down? Does it fail the action? Or does it have a way to report the problem and move on?

FlashyReese commented 2 years ago

It will be skipped but I'm not sure if the workflow will be marked as failed. I have had it happen once. Here is how it looks https://github.com/FlashyReese/reeses-sodium-options/runs/5475562683?check_suite_focus=true