search

AMontgomerie / question_generator

An NLP system for generating reading comprehension questions
MIT License
281 stars 72 forks source link

Error in qg training #7

Closed hyssss closed 2 years ago

hyssss commented 3 years ago

Hi @AMontgomerie ,

I just found an error in qg_training.ipynb. In last cell of qg_training.ipynb, the function train() should have parameters. Is SAVED_MODEL_PATH the same to TEMP_SAVE_PATH?

Thanks, Yu

AMontgomerie commented 3 years ago

Hi, sorry for the slow response.

You're right, I must've changed something without rerunning all the cells at some point. I should probably refactor the notebook into a script to avoid this kind of thing.

Yes, TEMP_SAVE_PATH should also be replaced with SAVED_MODEL_PATH.