Handle unused results - Githubissues

AMythicDev / minus

An asynchronous, runtime data feedable terminal paging library for Rust

https://crates.io/crates/minus/

Apache License 2.0

321 stars 23 forks source link

Handle unused results #11

Closed poliorcetics closed 3 years ago

poliorcetics commented 3 years ago

Fix #9.

This PR will, when done, introduce breaking changes: a major version will have to be released to avoid breaking user code (notably pijul).

Those breaking changes will be caused by the function now returning a minus::Result type

TODO LIST:

[x] Add an Error type and publicly export it.
[x] Handle unused results in static_pager.rs.
[x] Handle unused results in rt_wrapper.rs.
[x] Update examples.
[x] Mark breaking change in Cargo.toml by increasing major version number.

poliorcetics commented 3 years ago

This PR is now done. 😄

I don't think a minus 2.0.0 should be published just now, I would like to do some more refactoring in one (or maybe several) other PR, I saw what look liked some missed opportunities for less allocations.

AMythicDev commented 3 years ago

I reviewed their PR. There are some changes (in the line numbers section) to maybe force allow line numbers or permanently disable it . Anyway Thanks for PR, I am merging it.

As you stated about breaking changes that pijul may suffer from, I don't think they have even started working on implementing it