AMythicDev / minus

An asynchronous, runtime data feedable terminal paging library for Rust
https://crates.io/crates/minus/
Apache License 2.0
317 stars 23 forks source link

adding "rust-src" to devShell #125

Closed TornaxO7 closed 8 months ago

TornaxO7 commented 8 months ago

rust-analyzer doesn't work for me, because I also need rust-src but flakes override wipes the entries in the toolchain.

AMythicDev commented 8 months ago

I think the best option then would be to just drop the rust-toolchain.toml and configure the devShell in flake.nix only.

TornaxO7 commented 8 months ago

I think the best option then would be to just drop the rust-toolchain.toml and configure the devShell in flake.nix only.

so you would say that you don't want the rust-toolchain.toml at all? I mean, it's also helpful for non-nix-users.

AMythicDev commented 8 months ago

I think that's enough clear in the README about the MSRV plus there's no such problem with the nightly release (I can say that because I run the latest nightly) and all the intermediate releases. Hence I don't know how useful is that file for non-nix user. I mean I atleast have to run cargo with +nightly flag always. Rest I can only respect other people's DXs on this stuff.

TornaxO7 commented 8 months ago

Okeydokey!

TornaxO7 commented 8 months ago

done!

AMythicDev commented 8 months ago

Merged.