search

AMythicDev / minus

An asynchronous, runtime data feedable terminal paging library for Rust
https://crates.io/crates/minus/
Apache License 2.0
316 stars 23 forks source link

Changes regarding searching and others #20

Closed AMythicDev closed 3 years ago

AMythicDev commented 3 years ago

Although searching has been implemented, there is one major bug and a missing feature

  1. If search is involved twice with the same query, the search results are duplicated
  2. Backward searching is yet to be implemented

Also dynamic_output function has probably grown too much. Clippy is already warning about it. Therefore we should probably break it into smaller functions

AMythicDev commented 3 years ago

Release v3.0.1 fixes the first bug

AMythicDev commented 3 years ago

Release v3.1.0 adds backward searching but there is a issue where the cursor is placed in wrong position if upper_mark is changed manually by the user

AMythicDev commented 3 years ago

I think this bug has already been fixed. Closing the issue