search

AMythicDev / minus

An asynchronous, runtime data feedable terminal paging library for Rust
https://crates.io/crates/minus/
Apache License 2.0
321 stars 23 forks source link

Utils tests #5

Closed poliorcetics closed 3 years ago

poliorcetics commented 3 years ago
poliorcetics commented 3 years ago

I want to add tests with line numbers next but the current tests are done. This is not ready to be merged though

AMythicDev commented 3 years ago

First of all, thanks again for your help. When you're done, mark the PR as done. Since there are some major changes, I would go for a manual check before merging

poliorcetics commented 3 years ago

For I left the unhandled-Results as-is. I will address them in a follow-up PR when (if) this merged.

EDIT: I'm quite busy working on rust-lang/rust itself so if I don't answer/do something about your comments within a few days, feel free to ping me again. 😄

AMythicDev commented 3 years ago

Thanks for the PR. I have merged your changes