Closed jrb0001 closed 1 year ago
There are some extra break lines that got there probably because of some merge conflicts.
Makes sense, but I still had to move the locking out of the match. PR will follow after I verified it in my application.
I actually didn't knew about crossbeam_utils::atomics::AtomicCell
so I just went ahead with parking_lot since I also needed to used it in other places. I will consider it in later phases.
Describe the bug It is currently not possible to show a second pager after the first (static) one finished.
To Reproduce
Expected behavior It is possible to show many pagers sequentially.
Desktop:
Additional context The changes from #82 are not complete. There is still one break each in the static/dynamic match which doesn't reset
RUNMODE
.On the main branch, adding the missing reset leads to a deadlock. I think the dereferenced
MutexGuard
from thematch
is kept until the end of thematch
block. I didn't continue here because I ran into scrolling issues (#86).Is there a reason why you need a
Mutex
? Otherwise atomics (for example crossbeam_utils::atomicAtomicCell) would be much easier to use for this.