AN3223 / dotfiles

MIT License
35 stars 9 forks source link

mpv shaders : terrible arifacts with temporal variants of nlmeans #10

Open hooke007 opened 1 year ago

hooke007 commented 1 year ago

I know they are "Very experimental and buggy" Open an issue to record its behav may be better.

I only tested the shaders in hq folder. https://github.com/AN3223/dotfiles/commit/d682103432abd3cd892344f0b5691c8e1d7a0154

Sometimes the artifacts were dots instead of blocks.

The one possible reason is that the lack of scene's changing's detection algorithm ? It's obvious those wrong pixels come from the last frame.(Also some next fram's pixels come into the last one.)

Trinity3e commented 1 year ago

How about with the lq ones?

hooke007 commented 1 year ago

Similar blocks.

AN3223 commented 1 year ago

Can you see if 31d545f helps? It appears to resolve it on my system, but the issue was always intermittent for me so it's difficult to be sure.

The one possible reason is that the lack of scene's changing's detection algorithm ? It's obvious those wrong pixels come from the last frame.(Also some next fram's pixels come into the last one.)

This is handled implicitly BTW.

hooke007 commented 1 year ago

It helps but not enough...hq

AN3223 commented 1 year ago

It helps but not enough...

What resolution is the source video?

hooke007 commented 1 year ago
AN3223 commented 1 year ago

Do you only see artifacts around motion now?

hooke007 commented 1 year ago

No, I could even see them on those static color-testing clip.

AN3223 commented 1 year ago

Is the clip 4K?

hooke007 commented 1 year ago

Yes but 1080p also showed many dots.

AN3223 commented 1 year ago

Ah, not sure then...

hooke007 commented 1 year ago

It seem to be another vulkan bug (Nvidia). All variants work well with gpu-context=win (WGL)

edit: Confirmed gpu-context=winvk for AMD is safe.

hooke007 commented 1 year ago

The workaround for windows Nvidia users: