search

ANL-CEEESA / UnitCommitment.jl

Optimization package for the Security-Constrained Unit Commitment Problem
Other
104 stars 24 forks source link

Add flexiramp #21

Closed oyurdakul closed 2 years ago

oyurdakul commented 2 years ago

Incorporated flexiramp products into the package

iSoron commented 2 years ago

Hi Ogun, thank you very much for the pull request! Sorry for the delay, I was away from the project for a while.

I have reformatted the source code according to our code conventions (using make format) and merged the latest changes from the dev branch into this PR. To fetch these changes to your machine, you can use git pull. Please let me know if you have any questions.

Everything looks good overall, but some of our automated tests are failing. You can see the failed test results on GitHub Actions. Could you try to fix these issues? After you push new changes to this PR, GitHub should automatically run the tests again.

iSoron commented 2 years ago

@oyurdakul It seems like some checks are still failing. Please let me know if you need help with these. I am currently waiting until this PR is done to merge the branch feature/reserves, which adds zonal reserves to the package.

iSoron commented 2 years ago

@oyurdakul If all the lint actions pass in your local machine but not on GitHub Actions, perhaps you are using a different version of the JuliaFormatter package. For this project we currently use version 0.14.4. You can install it as follows:

using Pkg
Pkg.add(PackageSpec(name="JuliaFormatter", version="0.14.4"))

You can also format the source code by running make format. This should automatically use the correct version.

oyurdakul commented 2 years ago

@iSoron Thanks for your help. The lint action fails also on my local machine. In fact, I created a new lint action that formats only the benchmark folder, and it fails as well although I did not modify it at all. I will try to sort it out asap.

oyurdakul commented 2 years ago

@iSoron Could you please approve the runs Add flexiramp Tests #445 and Add flexiramp lint #121 triggered by my latest commit b4bc50c? They should be working now.

iSoron commented 2 years ago

@oyurdakul Approved. I have also changed the repository settings so that approval is only required for accounts that are new to GitHub, not all first-time contributors to the project.

oyurdakul commented 2 years ago

Thanks @iSoron! All checks seem to have passed, let me know if there is anything else you need from my end.

iSoron commented 2 years ago

Thanks for the PR, @oyurdakul! I have merged it with a few minor edits. I've also added your name to the list of authors.