Closed rory42edwards closed 1 year ago
OK summary of meeting changes:
std::cout
and BoostStore::Print()
calls. If you want to leave some in you can replace them with Log
calls with suitable debugging verbosity.m_data->Stores["ANNIEEvent"]
created in the ANNIEEventBuilder
to single-entry booststore, since it doesn't need to be a multi-entry one.RunNumber
from the ANNIEEvent itself, rather than asking the user to provide it as a configuration file input variable.CStore.Get("LAPPDData", LData)
call in Stage1Data Tool to ensure that the retrieval succeeded, and that LData is subsequently not null, to avoid potential segmentation faults.switch
structure with a line to form a suitable string key using std::to_string
.new
call in the ANNIEEventBuilder Tool, and eliminates the possibility of carrying over BoostStore contents between Execute loops.I have completed all your improvements except the final one: writing the ANNIEEvent already in the DataModel into the output file causes a crash no matter which way I do it, so I have left it as the (admittedly clunky) version of being in a separate function. I still don't know why that didn't work, but I didn't want to spend a lot of time on it.
nice, thanks
Adding in Stage1Builder Tool to be used in the DataDecoder ToolChain. Creates a "Stage1Data" BoostStore which contains ANNIEEvent_noLAPPD BoostStore and individual LAPPD BoostStores.