[JOSS Review] Couldn't find the trained RCNN for the example data

ANP-Granular / ParticleTracking

Library and GUI for tracking (rod-like) particles on camera images in 2D and 3D

https://particletracking.readthedocs.io/en/latest/

GNU General Public License v3.0

2 stars 2 forks source link

[JOSS Review] Couldn't find the trained RCNN for the example data #75

Closed aquilesC closed 5 months ago

aquilesC commented 11 months ago

Describe the bug The documentation states that "With this app comes a trained RCNN for detecting rods from the example dataset" but couldn't find it.

A potential improvement: Instead of leaving the example data within the software, move it outside, to the root folder, or perhaps make it avilable independently on Zenodo.

JOSS Issue: https://github.com/openjournals/joss-reviews/issues/5986

a-niem commented 10 months ago

Trained RCNN versions were made available by @dmitrypuzyrev on Zenodo and can now be found here. @aquilesC: You can use the *.pt models to continue your review. The documentation will be adjusted accordingly.

mhubii commented 9 months ago

hi both, just seeing this issue. It should not be necessary to download manually. Please use torch hub, refer #85. Please further consider publishing as asset in release (although this is optional)

a-niem commented 5 months ago

A button has been added to the Detection tab that downloads the example model from Zenodo. The other example data won't be moved for now.