search

ANRGenstar / genstar

Generation of Synthetic Populations Library
20 stars 2 forks source link

make GosplInputDataManager use the Dictionnary type #47

Closed samthiriot closed 6 years ago

samthiriot commented 6 years ago

except if there is a good reason not to do it - what do you think @chapuisk ?

chapuisk commented 6 years ago

GosplInputDataManager decodes input data based on a broader scope configuration file -- GenstarConfigurationFile which can have many dictionaries and also information about how to parse data files (which type of separator in csv; how to read headers; etc.).

EDIT: I run deeper on GosplInputDataManager inner utility method and saw what you were pointing at ... I'll modify the behavior for process to broadly rely on dictionary rather than on collection of attributes

samthiriot commented 6 years ago

I started already, pull first !

chapuisk commented 6 years ago

Ok great ! I stated to work on it and saw one failure in the process: Recorded attribute are not recognize (I open an issue for this). EDIT: and yes it is related ;)

chapuisk commented 6 years ago

From my point of view GosplInputDataManager now only work on attribute based on ones provided by dictionaries

PS: dictionary takes only one 'n' in english