search

ANTsX / ANTs

Advanced Normalization Tools (ANTs)
Apache License 2.0
1.21k stars 381 forks source link

ENH: Add Ubuntu 24.04 #1751

Closed gdevenyi closed 6 months ago

gdevenyi commented 6 months ago

Add 24.04 by copy-paste of the existing GH action.

cookpa commented 6 months ago

Thanks, happy to add this, have you verified that it builds?

gdevenyi commented 6 months ago

I was expecting it to build here in the PR, but I guess it won't since its a release-only trigger. I'm trying to figure out how to do it manually on my fork now...

cookpa commented 6 months ago

It is annoying and I probably should make a workflow_dispatch option. The way I currently test is to make releases on my fork.

cookpa commented 6 months ago

You know, I will just test it, I have it all set up

gdevenyi commented 6 months ago

The way I currently test is to make releases on my fork.

I figured, I just tried that on my fork and it didn't work for me :-/

cookpa commented 6 months ago

Yeah, you have to enable actions, and then disable the ones you don't want...I will fix this because things break on release and it would be good to be able to test

cookpa commented 6 months ago

Looks like Actions is busy today, but will update when it runs

gdevenyi commented 6 months ago

How fast are the builds? I was looking at adding this https://github.com/marketplace/actions/ccache-for-gh-actions

But like this I can't really test it easily...

cookpa commented 6 months ago

About an hour. I've used the cache before in python, it can help but caches only last a week so they are good for a nightly build but not really for releases