ANTsX / ANTs

Advanced Normalization Tools (ANTs)
Apache License 2.0
1.21k stars 381 forks source link

GCC8 Compile Error in Atropos #732

Closed gdevenyi closed 5 years ago

gdevenyi commented 5 years ago

GCC8 has tightened up warnings vs errors and throws this error on build:

  47724 In file included from /home/nistmni/src/minc-toolkit-v2/ANTs/Examples/Atropos.cxx:16:
  47725 /home/nistmni/src/minc-toolkit-v2/ANTs/ImageSegmentation/antsAtroposSegmentationImageFilter.h: In member function 'void itk::ants::AtroposSegmentationImageFilter<TInputImage, TMaskImage, TClassifiedImage>::GetPriorLabelParameterMap()':
  47726 /home/nistmni/src/minc-toolkit-v2/ANTs/ImageSegmentation/antsAtroposSegmentationImageFilter.h:523:18: error: return-statement with a value, in function returning 'void' [-fpermissive]
  47727      return this->m_PriorLabelParameterMap;
  47728                   ^~~~~~~~~~~~~~~~~~~~~~~~
  47729 make[5]: *** [Examples/CMakeFiles/l_Atropos.dir/build.make:63: Examples/CMakeFiles/l_Atropos.dir/Atropos.cxx.o] Error 1

https://github.com/ANTsX/ANTs/blob/master/ImageSegmentation/antsAtroposSegmentationImageFilter.h#L523

ntustison commented 5 years ago

Thanks but this isn't our issue. Compare our current repo with what you're compiling above.

gdevenyi commented 5 years ago

very odd.. I looked back in time in the repo here and didn't see any changes on that line.

I'll have to figure out where that code changed.

thanks