search

ANTsX / ANTsR

R interface to the ANTs biomedical image processing library
https://antsx.github.io/ANTsR
Apache License 2.0
127 stars 35 forks source link

New progressbar output conflict #276

Closed dorianps closed 4 years ago

dorianps commented 5 years ago

Just a minor issue for @muschellij2 . Noticed that antsAverageImages now comes with a progress bar. https://github.com/ANTsX/ANTsRCore/blob/master/R/antsAverageImages.R#L67

That bar cannot be controlled or suppressed, and is impairing the display of outputs in LESYMAP. The function needs something like displayBar or showInfo argument. Not sure if we have a conventional name for such a variable in ANTsR. Do you like me to make that quick change or do you prefer to do it yourself?

I think in general these outputs should be accompanied with an argument to suppress them if needed.

muschellij2 commented 5 years ago

How is it impairing the outputs of LESYMAP?

On Tue, Jul 30, 2019 at 10:11 PM dorianps notifications@github.com wrote:

Just a minor issue for @muschellij2 https://github.com/muschellij2 . Noticed that antsAverageImages now comes with a progress bar. That bar cannot be controlled or suppressed, and is impairing the display of outputs in LESYMAP. The function needs something like displayBar or showInfo argument. Not sure if we have a conventional name for such a variable in ANTsR. Do you like me to make that quick change or do you prefer to do it yourself?

I think in general these outputs should be accompanied with an argument to suppress them if needed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ANTsX/ANTsR/issues/276?email_source=notifications&email_token=AAIGPLW6SC44A2DX3XWSVMTQCDYENA5CNFSM4IIBZOD2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HCOM4VA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIGPLUTS3G5VLHXSSHNRNDQCDYENANCNFSM4IIBZODQ .

-- Best, John

dorianps commented 5 years ago

Clutters the display window with information I don't like to show the user. Pic below.

image

muschellij2 commented 5 years ago

So more of a nuisance than impairment of the code, I think. You can also use supressMessages around the code too for now

On Tue, Jul 30, 2019 at 11:59 PM dorianps notifications@github.com wrote:

Clutters the display window with information I don't like to show the user. Pic below.

[image: image] https://user-images.githubusercontent.com/9083517/62182812-01b0bd80-b326-11e9-89f1-890c773768f1.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ANTsX/ANTsR/issues/276?email_source=notifications&email_token=AAIGPLUK3METBTGOCE4RKO3QCEEZDA5CNFSM4IIBZOD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3F7ZSI#issuecomment-516685001, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIGPLWHORNPMNP2INJPM43QCEEZDANCNFSM4IIBZODQ .

-- Best, John

dorianps commented 5 years ago

I don't think the progress bar is of type message, I even searched online how to suppress progress bars and people suggest to use capture.output which I cannot use. But if you think that is a message I can go back and try suppressMessages.

muschellij2 commented 5 years ago

Also - if the issue is with ANTsRCore, please put that in the ANTsRCore issues list, not ANTsR. Otherwise, it's hard to fix and actually close these issues effectively.