Closed muschellij2 closed 4 years ago
possibly here: https://github.com/ANTsX/ANTsR/blob/master/R/crossvalidatedR2.R#L30
the abpN4 bug should be fixed at least on the master branch - travis tests would fail otherwise.
I don't know if it's a by-product of the binary install. Can you try these examples locally on you machine, or simply run R CMD check on this ANTsR version?
Checks passed fine
On Wed, Oct 23, 2019 at 8:59 AM John Muschelli notifications@github.com wrote:
I don't know if it's a by-product of the binary install. Can you try these examples locally on you machine, or simply run R CMD check on this ANTsR version?
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/ANTsX/ANTsR/issues/283?email_source=notifications&email_token=AACPE7XVGHUAVLT74S3AC6DQQBDEFA5CNFSM4JEAWDY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECBJ65Y#issuecomment-545431415, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPE7XXGAJYVOKK2BVJP7LQQBDEFANCNFSM4JEAWDYQ .
--
brian
Really confused then why it’s failing on travis
On Thu, Oct 24, 2019 at 5:29 AM stnava notifications@github.com wrote:
Checks passed fine
On Wed, Oct 23, 2019 at 8:59 AM John Muschelli notifications@github.com wrote:
I don't know if it's a by-product of the binary install. Can you try these examples locally on you machine, or simply run R CMD check on this ANTsR version?
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub < https://github.com/ANTsX/ANTsR/issues/283?email_source=notifications&email_token=AACPE7XVGHUAVLT74S3AC6DQQBDEFA5CNFSM4JEAWDY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECBJ65Y#issuecomment-545431415 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AACPE7XXGAJYVOKK2BVJP7LQQBDEFANCNFSM4JEAWDYQ
.
--
brian
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ANTsX/ANTsR/issues/283?email_source=notifications&email_token=AAIGPLQNTZOAMV57XRRAHATQQFTHNA5CNFSM4JEAWDY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEL3YQ#issuecomment-545832418, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIGPLSS3X7MABK7SF2U3JLQQFTHNANCNFSM4JEAWDYQ .
-- Best, John
Is there a call to the system RNG in
getASLNoisePredictors
somewhere I'm not seeing? It would seem to fail in all Linux builds with the test I have from OSX: https://travis-ci.org/ANTsX/ANTsR/jobs/601412222#L4071 and https://travis-ci.org/muschellij2/ANTsR/jobs/601551393#L4071I have checked the results on our cluster Centos 7 system and the means are equal. Is this possible to test in your docker image?
OSX on the other hand fails with a different error with abpN4: https://travis-ci.org/muschellij2/ANTsR/jobs/601551397#L6263, which I see
which I don't know if it's similar to https://github.com/stnava/ITKR/issues/43, but it would seem as though something odd is going on with the ITK build. But my local install of ANTsR using stnava/ITKR@98afc3a works fine with the
abpN4
test.