search

ANTsX / ANTsR

R interface to the ANTs biomedical image processing library
https://antsx.github.io/ANTsR
Apache License 2.0
127 stars 35 forks source link

getSyMG function #297

Closed muschellij2 closed 4 years ago

muschellij2 commented 4 years ago

The function getSyMG is defined in 2 different places, depending on the normalize flag: https://github.com/ANTsX/ANTsR/blob/master/R/multiscaleSVDxpts.R#L3155 https://github.com/ANTsX/ANTsR/blob/master/R/multiscaleSVDxpts.R#L3139

The issue is that the line that calls getSyMG only uses the first function arguments: https://github.com/ANTsX/ANTsR/blob/master/R/multiscaleSVDxpts.R#L3241 so if we ever use energyType = "normalized" in symlr, I believe this will fail:

stnava commented 4 years ago

am working on this - hoping to finish up today.