search

ANTsX / ANTsRCore

Rcpp bindings for the C++ ANTs library used by the ANTsR package
9 stars 9 forks source link

ENH: Add second version of N3 #126

Closed ntustison closed 3 years ago

ntustison commented 3 years ago

Hey @stnava , can you provide a bit more detail about tagging an ITKR version? As you can see, this pull request is still failing due to the recent migration of certain classes to the AdaptiveDenoising module and those classes are somehow not available to programs in ANTsRCore. However, I've checked and it looks like the correct ITK git tag is there in both the ITKR and ANTsRCore repos. I've tried clearing the travis build caches but I can't get the repo to build. Thanks.

muschellij2 commented 3 years ago

You need to tag the release for ITKR so that it creates a release because it takes forever to build it, we use the binary release from GitHub. So for Travis, you need to use a binary ITKR that reflects this: See https://travis-ci.org/github/ANTsX/ANTsRCore/jobs/735786279#L6943 for wh Best, John

On Thu, Oct 15, 2020 at 11:47 AM Nick Tustison notifications@github.com wrote:

Hey @stnava https://github.com/stnava , can you provide a bit more detail about tagging an ITKR version? As you can see, this pull request is still failing due to the recent migration of certain classes to the AdaptiveDenoising module and those classes are somehow not available to programs in ANTsRCore. However, I've checked and it looks like the correct ITK git tag is there in both the ITKR and ANTsRCore repos. I've tried clearing the travis build caches but I can't get the repo to build. Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ANTsX/ANTsRCore/pull/126#issuecomment-709415949, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIGPLUDKBYGICDSDTX24T3SK4KQBANCNFSM4SNFOXGA .

ntustison commented 3 years ago

Awesome. Thanks for the explanation (and relief from the frustration of trying to figure out what I was missing)---much appreciated, @muschellij2 .

ntustison commented 3 years ago

Thanks @stnava for the ITKR tag update. It looks like it's passing now.

ntustison commented 3 years ago

The required builds are all green.