ENH: multi-metric for antsRegistrationSyN

ANTsX / ANTsRCore

Rcpp bindings for the C++ ANTs library used by the ANTsR package

9 stars 9 forks source link

ENH: multi-metric for antsRegistrationSyN #150

Closed ntustison closed 1 year ago

ntustison commented 2 years ago

Hey @stnava , I can't reproduce these failures on my machine nor can I figure out what's going on. It would seem there's an issue with the AdaptiveDenoising Module and the associated enumerated types defined there. Have you had issues with compilation recently?

stnava commented 2 years ago

hi @ntustison

I have not seen these errors either - I can probably try to look further over the Labor Day weekend ....

may need an ITK version update ( ie update ITKR tag ) ... when making changes that involve C++ ... just a guess.

ntustison commented 2 years ago

Awesome. Thanks. The changes I made were internal to antsRegistration.R so no C++ changes but who knows. Thanks again.

ntustison commented 2 years ago

One potentially relevant difference between my local build and the GitHub checks is the ITKR versions:

Local build: ITKR_0.6.0.0.2 from stnava/ITKR
GitHub check: ITKR 0.5.3.3 2022-09-02 [1] Github (adigherman/ITKR@186128b)

ntustison commented 1 year ago

Okay, updating to ITK_RC04 seems to have fixed the issue. Now the problem seems to be with the checks that were there in the previous commit. I'm going to go ahead and merge since it fixes the compilation and worry about the checks later.