search

ANTsX / ANTsRCore

Rcpp bindings for the C++ ANTs library used by the ANTsR package
9 stars 9 forks source link

Potentially removing `colormap` #74

Closed muschellij2 closed 5 years ago

muschellij2 commented 5 years ago

So colormap requires V8 which requires a 3rd party install of v8 on machine. Probably going to cause some headaches downstream for installers. Maybe use the viridis package if wanting that palette? https://cran.r-project.org/web/packages/viridis/vignettes/intro-to-viridis.html. Or you can use colorRampPalette or colorRamp.

muschellij2 commented 5 years ago

It's a heavy dependency for https://github.com/ANTsX/ANTsRCore/blob/master/R/plot.antsImage.R#L383 https://github.com/ANTsX/ANTsRCore/blob/master/R/plot.antsImage.R#L414

stnava commented 5 years ago

we had viridis as a package dependency for a long time ( in ANTsR )

colormap advantages: one line to have access to a bunch of different useful common color mapping schemes

disadvantages: dependencies, does not have basic maps like red, blue

anyway, those are my comments. i would suggest a fork that works on the various issues associated wtih plot.antsImage many of which go beyond this. it should be rewritten, decluttered.

stnava commented 5 years ago

Closed by removing these dependencies.