search

ANU-Rocketry / control-panel

Control panel for ANU Rocketry's liquid rocket engine testing platform
3 stars 0 forks source link

better ups status written #18

Closed Glubs9 closed 1 year ago

Glubs9 commented 2 years ago

should solve #3

additionally from the changes listed in #3 there has been a small change to the test server to make it change ups status every 3 seconds for testing. I feel this is maybe worth leaving in just in case something else comes up that is reliant on the UPS status.

Glubs9 commented 2 years ago

(sorry, it has been a while since I last used node so I'm still getting used to it so I'm not sure what is going on with the package-lock.json. Apologies)

OliverBalfour commented 1 year ago

Cheers, looks good!

I've removed the edit to package-lock.json from your commit. If you want to undo changes like this in future, you can git reset --soft HEAD^ to undo your commit, git restore --staged package-lock.json to unstage the file, git checkout package-lock.json to delete the changes, then git commit -c ORIG_HEAD to commit it again with the old message. Git has lots of confusing processes like this, so StackOverflow is your friend!

To avoid lockfile issues in future, make sure to run npm ci to install all the packages instead of npm install, this installs the exact versions you ask for without updating them.

I've just changed the timer from 3 seconds to 60 seconds. 3 seconds is great for testing your branch works, but it'll get irritating after it's merged