Abort sequence interrupt may fail if valves are in the wrong initial state?

ANU-Rocketry / control-panel

Control panel for ANU Rocketry's liquid rocket engine testing platform

3 stars 0 forks source link

Abort sequence interrupt may fail if valves are in the wrong initial state? #23

Closed OliverBalfour closed 1 year ago

OliverBalfour commented 1 year ago

Untested hunch, this depends on the structure of the abort sequence. This will be fixed in #8

My hunch is that if pressurisation is open, and you press abort mid sequence, and abort tries to open vent at the very start, opening vent will be ignored because that puts the system in an illegal state. Instead, we should make the action of opening vent/pres close pres/vent respectively, implicitly.

OliverBalfour commented 1 year ago

Fixed in e911c22d37fdb40e0683b4388686bbee76770c35