search

ANXS / nginx

A fairly flexible and feature full Ansible role for the NGINX web server.
MIT License
151 stars 82 forks source link

add geoip module support #66

Closed TinOo512 closed 8 years ago

TinOo512 commented 8 years ago

https://github.com/ANXS/nginx/issues/4

We moved the work of @welcoMattic (https://github.com/ANXS/nginx/pull/46) in our organisation.

So this PR is now split and clean.

farridav commented 8 years ago

Nice contribution! do we want to default this to on? its going to cause everyone using this role that is building from source to have to recompile their nginx installation (that includes me) or add nginx_geoip:·'off' into their playbooks

I suppose the bigger question here is do we want to add all new features into the nginx build by default @otakup0pe @soupdiver @pjan?

otakup0pe commented 8 years ago

My preference is for the default behavior when adding (most) features is to remain the same. To that end, this (and other modules) should probably not be enabled by default.

farridav commented 8 years ago

If we can get this feature disabled by default, happy to get it merged in :) separate to this, we will add a note to the README specifying the process for adding new features going forwards :)

TinOo512 commented 8 years ago

I renamed the key in the nginx_source_modules_included and I disabled the module by default.

But maybe we should remove it from nginx_source_modules_included because even if it's disable it will be include in the nginx build.

Also let me know if I should squash my commits :)

farridav commented 8 years ago

I guess its ok to leave it in the source modules because anyone choosing to build from source, will probably be doing it so they can use their own compile flags within nginx_source_modules_included so will not be affected by this addition... squashing into the first commit would be awesome! keep the mainline clean... will keep a close eye on this and aim to get this in as soon as squashed.. thanks for your contribution :)

TinOo512 commented 8 years ago

Done :)