make hostname update as optional

ANXS / nginx

A fairly flexible and feature full Ansible role for the NGINX web server.

MIT License

151 stars 82 forks source link

Open TinOo512 opened 8 years ago

TinOo512 commented 8 years ago

We moved the work of @welcoMattic (https://github.com/ANXS/nginx/pull/48) in our organisation.

So this PR is now split and clean.

farridav commented 8 years ago

Seems fine to me.... @soupdiver seems like you've been following this thread? care to merge?

otakup0pe commented 8 years ago

I like this concept, but it changes the default behavior of the role. @soupdiver thoughts ?

TinOo512 commented 8 years ago

Like geoip I can set hostname_update: true by default. Let me know :)

soupdiver commented 8 years ago

Agree with @otakup0pe that we should keep the behaviour backwards compatible. So changing the default would be nice :)

TinOo512 commented 8 years ago

@soupdiver done :)

soupdiver commented 8 years ago

LGTM

otakup0pe commented 7 years ago

If we can get the conflict dealt with I'll totally merge this.

Also if y'all are interested in helping formally maintain this role, let me know.