Should we use no_log for postgresql_user?

ANXS / postgresql

Fairly full featured Ansible role for Postgresql.

http://anxs.io/

MIT License

855 stars 576 forks source link

Closed thbar closed 6 years ago

thbar commented 7 years ago

Today I noticed that when using a password: {{ key }} (with the key stored encrypted via ansible-vault), the password will show up in the log.

As seen here, maybe it would be a good idea to specify no_log here, like is done in ANXS.generic-users?

otakup0pe commented 7 years ago

Haha wow yeah we should.

thbar commented 6 years ago

@otakup0pe I have little knowledge of how tweaking this could impact anything, but I could issue a PR.

Is it worth submitting a PR for? Thanks!

otakup0pe commented 6 years ago

Absolutely worthy of a PR! Existing tests should cover any addition of no_log to existing actions.

thbar commented 6 years ago

@otakup0pe PR issued at #275.

Re: tests, I wonder if adding tests with inspec or his older brother serverspec could maybe ease both contributions & maintenance.

Just a though!