ANXS / postgresql

Fairly full featured Ansible role for Postgresql.
http://anxs.io/
MIT License
855 stars 576 forks source link

Allow repo to be optional, in case of Satellite, Artifactory, etc. #343

Closed gclough closed 6 years ago

gclough commented 6 years ago

If a local repo such as Satellite, Artifactory, etc. is being used, then sometimes you do NOT want the actual PGDG repo to be installed. In fact, in some sites it fails outright as the target server doesn't have outbound internet access that's required to install the repo.

gclough commented 6 years ago

By default, this will behave the same as normal:

TASK [ANXS.postgresql : PostgreSQL | Add PostgreSQL repository] ****************
changed: [postgresql-9.3]
changed: [postgresql-9.5]
changed: [postgresql-10]
changed: [postgresql-9.4]
changed: [postgresql-9.6]

Only when the postgresql_install_repository variable is set to false will it skip that section.

aoyawale commented 6 years ago

going to add this vars for the fedora.yml in https://github.com/ANXS/postgresql/pull/325 to stay consistant.

gclough commented 6 years ago

Good idea @jlozadad. How can we review/merge this so that it's not left hanging, thus blocking your PR?

aoyawale commented 6 years ago

I'll have to test it.

aoyawale commented 6 years ago

tested with vagrantfile and ran 3 times for idempotency.