search

ANXS / postgresql

Fairly full featured Ansible role for Postgresql.
http://anxs.io/
MIT License
855 stars 576 forks source link

Rpm variable name change to 340 #352

Closed gclough closed 6 years ago

gclough commented 6 years ago

A general tidy up of the install section, and some variable renames.

gclough commented 6 years ago

@jlozadad , I've made some variable name changes that I proposed in the comments of #340, but I've also done a little tidy up of the install section, making changes to the recent Fedora support you added.

Can you see if this makes sense to you?

gclough commented 6 years ago

@NissesSenap , I never understood why the ansible_distribution was included, so I've removed them. All of the commands are apt/yum/dnf should work, as they test the package manager before including them.

aoyawale commented 6 years ago

the reason ansible_distribution was included so that it picks up fedora properly. If you use the regular os_family* it will show as red hat and run install_yum. adding those vars in the main.yml prevents them from being ran on both since fedora still uses yum.

gclough commented 6 years ago

This should fix the current broken-build problem, but it does more than just fix that. I don't think there's a mega-rush to fix the build, but if this could be reviewed and merged soon-ish, then that would put us in a good place IMHO.

Thanks @NissesSenap, @jlozadad , and @UnderGreen for your input and help thus far. If you're capable of squashing the commits and doing so under your account, that would be good so someone else get credit too, right?

aoyawale commented 6 years ago

looks like everything passed now.