search

ANXS / postgresql

Fairly full featured Ansible role for Postgresql.
http://anxs.io/
MIT License
855 stars 576 forks source link

Disable Fedora testing, as PostgreSQL v9.3 doesn't exist #354

Closed gclough closed 6 years ago

gclough commented 6 years ago

The missing PostgreSQL v9.3 version for Fedora is causing the build to fail, so I've disabled it until we can make it skip this specific platform/version combination.

There will never be a pre-packaged v9.3 for Fedora, so we need to handle this situation gracefully.

gclough commented 6 years ago

@jlozadad, @UnderGreen I've disabled Fedora, as it's breaking the Travis tests. Can you merge this so that the master branch will pass the auto-tests? We can add it back in once we figure out how to selectively skip the Fedora/PG v9.4 combination.

UnderGreen commented 6 years ago

@jlozadad why did you merge this one? There were errors in travis testing related to changes here.

gclough commented 6 years ago

Fedora doesn't have a v9.3 release... and won't ever have one available. Basically this is to disable the Fedora testing (thus causing all other Travis tests to fail) until we can selectively filter out the Fedora/v9.3 Travis test.

gclough commented 6 years ago

Oh I see what you mean:

TASK [ANXS.postgresql : PostgreSQL | Make sure the postgres data directory exists] ***
fatal: [postgresql-9.4]: FAILED! => {"changed": false, "failed": true, "gid": 0, "group": "root", "mode": "0755", "msg": "chown failed: failed to look up user postgres", "owner": "root", "path": "/var/lib/pgsql", "size": 4096, "state": "directory", "uid": 0}
fatal: [postgresql-9.6]: FAILED! => {"changed": false, "failed": true, "gid": 0, "group": "root", "mode": "0755", "msg": "chown failed: failed to look up user postgres", "owner": "root", "path": "/var/lib/pgsql", "size": 4096, "state": "directory", "uid": 0}
fatal: [postgresql-9.3]: FAILED! => {"changed": false, "failed": true, "gid": 0, "group": "root", "mode": "0755", "msg": "chown failed: failed to look up user postgres", "owner": "root", "path": "/var/lib/pgsql", "size": 4096, "state": "directory", "uid": 0}
fatal: [postgresql-10]: FAILED! => {"changed": false, "failed": true, "gid": 0, "group": "root", "mode": "0755", "msg": "chown failed: failed to look up user postgres", "owner": "root", "path": "/var/lib/pgsql", "size": 4096, "state": "directory", "uid": 0}
fatal: [postgresql-9.5]: FAILED! => {"changed": false, "failed": true, "gid": 0, "group": "root", "mode": "0755", "msg": "chown failed: failed to look up user postgres", "owner": "root", "path": "/var/lib/pgsql", "size": 4096, "state": "directory", "uid": 0}
    to retry, use: --limit @/home/travis/build/ANXS/postgresql/tests/docker/site.retry

That wasn't introduced by this change, so we need to go back in the merges to find out when it was introduced.

UnderGreen commented 6 years ago

@gclough I just wanted to point do not merge changes with broken tests :grinning:

gclough commented 6 years ago

Sure... I think it was introduced by #325... but I'm not sure:

What does this do?

-    machine.vm.box = "centos/7"
+    #machine.vm.box = "centos/7"
+     machine.vm.box = "fedora/27-cloud-base"
gclough commented 6 years ago

Actually, I think it was due to the install filter from the Fedora change not also including "CentOS". I've updated that in #352