ANXS / postgresql

Fairly full featured Ansible role for Postgresql.
http://anxs.io/
MIT License
850 stars 573 forks source link

error in README pass: pass #385

Closed Pepan closed 1 year ago

Pepan commented 5 years ago
# List of users to be created (optional)
postgresql_users:
  - name: baz
    pass: pass
    encrypted: no       # denotes if the password is already encrypted.

should be

# List of users to be created (optional)
postgresql_users:
  - name: baz
    password: pass
    encrypted: no       # denotes if the password is already encrypted.
otakup0pe commented 5 years ago

Pull requests for easy doc fixes are always welcome!

erdenezul commented 5 years ago

In tasks/users.yml, it used as {{item.pass}. So, it should be pass. @Pepan

- name: PostgreSQL | Make sure the PostgreSQL users are present                
  postgresql_user:                                                             
    name: "{{item.name}}"                                                      
    password: "{{ item.pass | default(omit) }}"                                
    encrypted: "{{ item.encrypted | default(omit) }}"                          
    port: "{{postgresql_port}}"                                                
    state: present                                                             
    login_user: "{{postgresql_admin_user}}"                                    
  no_log: true                                                                 
  become: yes                                                                  
  become_user: "{{postgresql_admin_user}}"                                     
  with_items: "{{postgresql_users}}"                                           
  when: postgresql_users|length > 0
erdenezul commented 5 years ago

@otakup0pe If you would like to change from pass to password for better readable, I want to submit PR

erdenezul commented 5 years ago

Otherwise, I believe we can close this issue

otakup0pe commented 5 years ago

PR's always welcome!