ANXS / postgresql

Fairly full featured Ansible role for Postgresql.
http://anxs.io/
MIT License
850 stars 573 forks source link

PostgreSQL 11 support - config file template #395

Closed vladimir-mencl-eresearch closed 5 years ago

vladimir-mencl-eresearch commented 5 years ago

Hi,

Thank you all for providing this role - we find it very useful.

I wanted to use the role with PostgreSQL 11, and I saw it wasn't supported yet, so I started adding support.

I created the config file template based on the PostgreSQL 10 template, but I went though all the changes between the plain vanilla config files and applied all of these changes to the config file template - commit history included.

I see there already is another PR for PostgreSQL 11 (#384 by @irionr); I see these pull requests as complements. My PR only provides the config file template (while #384 so far uses an exact copy of the PSQL 10 template for PSQL 11).

Please let me know if you'd be happy to merge this contribution.

Cheers, Vlad

Doctorbal commented 5 years ago

Thank you @vladimir-mencl-eresearch for getting this done.

When do we see the possibility of this merging given that this has been checked and passed?

Kocal commented 5 years ago

Hi, do you have an idea of when this will be merged? Thanks!

gclough commented 5 years ago

Hi @vladimir-mencl-eresearch . I took and old PR of mine #333 and refreshed it into #405. This is now merged, so the role supports v11. That supersedes this, so I hope you don't mind if I close it?

You may note a few other things that needed changing, and I hope you'll do the v12 patch!

Cheers, Greg.