template/postgresql.conf-9.3.j2: Don't use the include variables if they are False.

[gordeevbr]

These changes are propagated from the 9.4 config template. Without these changes, PostgreSQL service doesn't start for me, rightfully claiming that the config is invalid. Unfortunately, I couldn't test them with Vagrant, but I ran this against my local installation and it was fine. Thank you in advance!

[gclough]

It looks like the build failed on Fedora, so I've restarted it for you. If it fails again, can you figure out why?

[gordeevbr]

Greetings. I went through the logs, it seems to me it can't download some packages with dnf. If the error persists, I'll see what I can do.

[gclough]

Also, we don't officially support v9.3 any longer as that version was end-of-life on November 8, 2018:

https://www.postgresql.org/support/versioning/

If it builds then I have no objection to merging it, but we shouldn't spend too much time on the older versions if we can avoid it.

[gclough]

@nysan , do you have any idea why Fedora is failing now?

TASK [ANXS.postgresql : PostgrSQL | Install all the required depedencies | dnf] ***
fatal: [postgresql-9.4]: FAILED! => {"changed": false, "cmd": "dnf install -y python2-dnf", "failed": true, "msg": "Error: Unable to find a match", "rc": 1, "stderr": "Error: Unable to find a match\n", "stderr_lines": ["Error: Unable to find a match"], "stdout": "Last metadata expiration check: 0:00:53 ago on Tue Jun 18 15:36:48 2019.\nNo match for argument: python2-dnf\n", "stdout_lines": ["Last metadata expiration check: 0:00:53 ago on Tue Jun 18 15:36:48 2019.", "No match for argument: python2-dnf"]}
fatal: [postgresql-10]: FAILED! => {"changed": false, "cmd": "dnf install -y python2-dnf", "failed": true, "msg": "Error: Unable to find a match", "rc": 1, "stderr": "Error: Unable to find a match\n", "stderr_lines": ["Error: Unable to find a match"], "stdout": "Last metadata expiration check: 0:00:53 ago on Tue Jun 18 15:36:48 2019.\nNo match for argument: python2-dnf\n", "stdout_lines": ["Last metadata expiration check: 0:00:53 ago on Tue Jun 18 15:36:48 2019.", "No match for argument: python2-dnf"]}
fatal: [postgresql-11]: FAILED! => {"changed": false, "cmd": "dnf install -y python2-dnf", "failed": true, "msg": "Error: Unable to find a match", "rc": 1, "stderr": "Error: Unable to find a match\n", "stderr_lines": ["Error: Unable to find a match"], "stdout": "Last metadata expiration check: 0:00:53 ago on Tue Jun 18 15:36:48 2019.\nNo match for argument: python2-dnf\n", "stdout_lines": ["Last metadata expiration check: 0:00:53 ago on Tue Jun 18 15:36:48 2019.", "No match for argument: python2-dnf"]}
fatal: [postgresql-9.6]: FAILED! => {"changed": false, "cmd": "dnf install -y python2-dnf", "failed": true, "msg": "Error: Unable to find a match", "rc": 1, "stderr": "Error: Unable to find a match\n", "stderr_lines": ["Error: Unable to find a match"], "stdout": "Last metadata expiration check: 0:00:54 ago on Tue Jun 18 15:36:48 2019.\nNo match for argument: python2-dnf\n", "stdout_lines": ["Last metadata expiration check: 0:00:54 ago on Tue Jun 18 15:36:48 2019.", "No match for argument: python2-dnf"]}
fatal: [postgresql-9.5]: FAILED! => {"changed": false, "cmd": "dnf install -y python2-dnf", "failed": true, "msg": "Error: Unable to find a match", "rc": 1, "stderr": "Error: Unable to find a match\n", "stderr_lines": ["Error: Unable to find a match"], "stdout": "Last metadata expiration check: 0:00:53 ago on Tue Jun 18 15:36:48 2019.\nNo match for argument: python2-dnf\n", "stdout_lines": ["Last metadata expiration check: 0:00:53 ago on Tue Jun 18 15:36:48 2019.", "No match for argument: python2-dnf"]}

[gordeevbr]

@gclough Are tests working for you in other branches? It seems to me that Fedora 27 dnf repos have changed their URLs to the archived ones since it reached its EOL. Don't claim to be an expert, but that's what I could think of.

[gclough]

Could you rebase this against master (with #447), as Fedora was killing the build

[gclough]

Even though we don't support v9.3 any longer, it would make sense to include this to help those that are still using it.

[gordeevbr]

Thanks!