Closed dracic closed 4 months ago
Ok, I'm fixing this. But errors that popped out for Fedora weren't caused by my commits.
Build fail related to: #444
For centOS 6 (or other RHEL upstart) service manager we need /etc/sysconfig/pgsql/clustername template to override default variables:
PGENGINE=/usr/pgsql-9.5/bin
PGDATA=/var/lib/pgsql/9.5/data
PGLOG=/var/lib/pgsql/9.5/pgstartup.log
# Log file for pg_upgrade
PGUPLOG=/var/lib/pgsql/$PGMAJORVERSION/pgupgrade.log
lockfile="/var/lock/subsys/${NAME}"
pidfile="/var/run/${NAME}.pid"
# Override defaults from /etc/sysconfig/pgsql if file is present
[ -f /etc/sysconfig/pgsql/${NAME} ] && . /etc/sysconfig/pgsql/${NAME}
I made a mess with commits, but now it works with CentOS 6 and 7.
Could you rebase this against master (with #447), as Fedora was killing the build
Rebase done!
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!
This pr has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.
So I noticed at the first play (CentOS) that configuration settings were not applied because systemd applied settings from data dir instead of /etc:
So we need extra handler for systemd config reload, and 'PostgreSQL | Use the conf directory when starting the Postgres service | RedHat' task should notify it on every systemd config change.